Fix: Expense Report Shows Incorrect Approver Message

by ADMIN 53 views

Hey guys, have you ever run into a weird message on Expensify when dealing with expense reports? Specifically, after changing the approver, you see something like "Waiting for to approve expenses" instead of the expected message? Well, you're not alone! This bug has been spotted and reported, and we're diving deep into the issue. This article will break down the problem, how to reproduce it, and what to do about it.

The Bug: A Misleading Message

So, what's the deal? The core issue lies in the incorrect message displayed after changing an expense report's approver. Instead of a clear message like "Waiting for [Approver's Name] to approve expenses," you get "Waiting for to approve expenses." It's like the app is missing some critical information, which can be confusing for users. Imagine trying to figure out who needs to approve the expense when the app doesn't tell you! This kind of glitch can mess up workflows and cause unnecessary delays. This bug impacts the user experience by creating uncertainty about the approval process.

This bug was reported by the Applause Internal Team. The version of Expensify experiencing this issue is 9.2.32-0. The issue is reproducible in the staging environment but hasn't been observed in production. This is good news, as it means the problem can be fixed before it affects all users. The bug was identified during regression testing, and the test details can be found on GitHub (https://github.com/Expensify/App/pull/70283). The issue was confirmed on MacOS using Chrome and Safari, and the desktop app.

How to Reproduce the Issue: Step-by-Step

Want to see this bug in action? Here's how you can reproduce it. Follow these steps carefully and you'll see the same message:

  1. Precondition: Make sure your workspace has at least two members. This is the starting point for the test.
  2. Go to staging: Head over to staging.new.expensify.com to start.
  3. Workspace Chat: Navigate to your workspace chat.
  4. Create an Expense: Create a new expense within the workspace chat.
  5. Open the Report: Open the expense report you just created.
  6. Submit the Expense: Click the "Submit" button.
  7. Change Approver (Step 1): Click "More," then select "Change approver."
  8. Add Approver (Step 1): Click "Add approver," then "Change approver."
  9. Workspace Upgrade (if needed): If prompted, upgrade your workspace and click "Change approver."
  10. Select and Save Approver: Choose a user and click "Save."
  11. Bypass Approver: Click "More," then "Bypass approver," and again "Change approver."
  12. Change Approver (Step 2): Click "More," then "Change approver."
  13. Add Approver (Step 2): Click "Add approver," then "Change approver."

After completing these steps, you should see the incorrect message: "Waiting for to approve expenses." This detailed breakdown of the reproduction steps allows developers and testers to easily verify the bug and confirm that the fix works.

Expected vs. Actual Results: The Discrepancy

Okay, so what were we supposed to see, and what did we actually see? The expected result is a clear message stating "Waiting for [Approver's Name] to approve expenses." This message tells the user exactly who is responsible for the approval, which is crucial for transparency and efficient workflow.

The actual result, however, is the bug: "Waiting for to approve expenses." The missing approver's name is the problem. This leaves the user in the dark, wondering who has to take action, and creates confusion. This small but significant detail significantly impacts the user experience.

The Impact of the Bug

This might seem like a small glitch, but it can create problems. Here’s why it's important:

  • User Confusion: Users might not know who's supposed to approve the expense, which can lead to delays.
  • Workflow Disruption: If the approver isn't clear, it can disrupt the entire expense reporting process.
  • Reduced Efficiency: It takes extra time and effort to figure out who the approver is.
  • Poor User Experience: It makes the app feel less reliable and trustworthy.

Basically, even small bugs can lead to a frustrating experience. It is important to fix bugs like this to provide a better user experience.

Workarounds and Resolutions

Unfortunately, the report doesn't offer any workarounds. It's a reminder of how important it is to find a fix ASAP. The absence of a workaround means users might have to take extra steps to figure out the approver.

As of now, there's no official workaround mentioned in the report. This is where the developers come in. They need to find out why the approver's name isn't being displayed correctly. The fix will likely involve checking the code responsible for displaying the message and ensuring that the approver's name is being correctly retrieved and rendered. The developers will need to thoroughly test the fix. They will need to ensure that the message displays correctly. After that, they will be able to push a fix to address the issue.

Platforms Affected

The bug appears on the following platforms:

  • MacOS: Chrome / Safari
  • MacOS: Desktop

It is important to note that the issue is specific to MacOS and is not reproducible on other operating systems like Android or iOS. This information is important for prioritizing fixes and ensuring that the fix will work on the specific platform.

What's Next?

So, what happens now? The Expensify team will likely investigate the issue. They will start by reviewing the code related to the approver message. They'll pinpoint where the approver's name is supposed to be pulled in and displayed. Then, they will fix the code and test to ensure it works correctly. The goal is to get that fix out to users as soon as possible, so no one has to deal with the confusing message. The Expensify team will probably start by assigning this bug to a developer who can investigate the code. The developer will then look for the root cause and implement a fix.

Keep an eye on Expensify updates to know when this bug is squashed!

Resources and Further Reading

Want to learn more? Check out the following:

By staying informed and getting involved, you can help improve Expensify and make it a better experience for everyone. Thanks for reading, and happy expensing!